Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture frame #105

Closed
wants to merge 15 commits into from
Closed

Picture frame #105

wants to merge 15 commits into from

Conversation

benpollarduk
Copy link
Owner

No description provided.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 95.80838% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.69%. Comparing base (1bde17f) to head (c0ee892).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
NetAF/Rendering/Console/AnsiColor.cs 82.35% 6 Missing ⚠️
NetAF/Rendering/Console/GridTextFrame.cs 60.00% 2 Missing ⚠️
NetAF/Rendering/Console/GridVisualBuilder.cs 98.40% 0 Missing and 2 partials ⚠️
NetAF/Rendering/Console/GridVisualFrame.cs 96.61% 0 Missing and 2 partials ⚠️
NetAF/Logic/Modes/DirectRenderMode.cs 83.33% 1 Missing ⚠️
.../Console/FrameBuilders/ConsoleSceneFrameBuilder.cs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   85.50%   86.69%   +1.19%     
==========================================
  Files         140      146       +6     
  Lines        3738     4014     +276     
  Branches      604      646      +42     
==========================================
+ Hits         3196     3480     +284     
+ Misses        337      330       -7     
+ Partials      205      204       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@benpollarduk benpollarduk deleted the picture-frame branch November 26, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant